[PATCH] D38614: [ELF][MIPS] Check for overflow when writing R_MIPS_CALL16 and R_MIPS_TLS_GOTTPREL

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 07:46:02 PDT 2017


atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM

I think it will be impossible to write a test case for this change when multi-GOT is implemented. The only option is to implement a "debug" command line option for disabling multi-GOT. Additional flag is redundant, but my patch has `mips-got-size` flag. I consider to treat a zero argument of this flag as a special value.


https://reviews.llvm.org/D38614





More information about the llvm-commits mailing list