[PATCH] D38535: [CGP] Separate Select and Phi case in optimizeMemoryInst

[John Brawn via Phabricator via llvm-commits]

john.brawn added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:4630
+                                     : AddressingModeCombiner::CombineByPhi;
+  if (!AddrModes.combineAddrModes(OnlySingleAddrMode, CombineType)) {
     TPT.rollback(LastKnownGood);
----------------
You could instead figure out if we have a select or phi by passing through Addr and checking its type. Or alternatively attach the select/phi to each ExtAddrMode that came from it (similar to what D38133 does with AddrModeUser) and examine the type of that.


https://reviews.llvm.org/D38535