[PATCH] D38190: Partial Inlining with multi-region outlining based on PGO information

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 18:30:00 PDT 2017


echristo added a comment.

One high level comment that I added inline as well:

What's the criteria for deleting the old code? When should we plan on doing this?



================
Comment at: lib/Transforms/IPO/PartialInlining.cpp:168-169
   struct FunctionCloner {
+    // Constructor with FunctionOutliningInfo should be removed once
+    // multi-region outlining work is complete.
     FunctionCloner(Function *F, FunctionOutliningInfo *OI);
----------------
When is this?


Repository:
  rL LLVM

https://reviews.llvm.org/D38190





More information about the llvm-commits mailing list