[PATCH] D38605: [MC] Move .seh_ directive implementation to MCObjectStreamer

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/include/llvm/MC/MCObjectStreamer.h:44
 
+  std::vector<WinEH::FrameInfo *> WinFrameInfos;
+  WinEH::FrameInfo *CurrentWinFrameInfo = nullptr;
----------------
Should this be `std::vector<std::unique_ptr<WinEH:FrameInfo>>` ?


================
Comment at: llvm/lib/MC/MCObjectStreamer.cpp:38-39
 MCObjectStreamer::~MCObjectStreamer() {
+  for (unsigned i = 0; i < getNumWinFrameInfos(); ++i)
+    delete WinFrameInfos[i];
   delete &Assembler->getBackend();
----------------
DeleteContainerPointers(WinFrameInfos)


================
Comment at: llvm/lib/MC/MCObjectStreamer.cpp:78-80
+  for (unsigned i = 0; i < getNumWinFrameInfos(); ++i)
+    delete WinFrameInfos[i];
+  WinFrameInfos.clear();
----------------
Ditto.


https://reviews.llvm.org/D38605