[PATCH] D38608: [sanitizer] Test ubsan and cfi on android.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 18:12:10 PDT 2017


vitalybuka added inline comments.


================
Comment at: compiler-rt/test/cfi/stats.cpp:9
+// FIXME: %t.stats must be transferred from device to host for this to work on Android.
+// UNSUPPORTED: android
+
----------------
I guess XFAIL is preferable for fixable issues. 
UNSUPPORTED may stay this way even If someone accidentally fix the issue for other reasons


================
Comment at: compiler-rt/test/ubsan/lit.common.cfg:50
+elif config.android:
+  default_ubsan_opts += ['abort_on_error=0']
+
----------------
Could we put this into top cfg?


https://reviews.llvm.org/D38608





More information about the llvm-commits mailing list