[PATCH] D38570: Support: Rewrite Windows implementation of sys::fs::rename to be more POSIXy.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 17:15:57 PDT 2017

Previous message: [PATCH] D38570: Support: Rewrite Windows implementation of sys::fs::rename to be more POSIXy.
Next message: [PATCH] D38570: Support: Rewrite Windows implementation of sys::fs::rename to be more POSIXy.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

rnk added a comment.

You might consider extending `unittests/Support/ReplaceFileTest.cpp` with any non-racy scenarios that needed thought.


https://reviews.llvm.org/D38570

Previous message: [PATCH] D38570: Support: Rewrite Windows implementation of sys::fs::rename to be more POSIXy.
Next message: [PATCH] D38570: Support: Rewrite Windows implementation of sys::fs::rename to be more POSIXy.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list