[PATCH] D38565: [lit] Improve the ToolSubst class a bit

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 15:49:26 PDT 2017


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/test/lit.cfg.py:137
+
+# FIXME: Why do we have both `lli` and `%lli` that do slightly different things?
+tools.extend([
----------------
I don't think we need this FIXME, it's explained above where we compute lli_args.


https://reviews.llvm.org/D38565





More information about the llvm-commits mailing list