[PATCH] D38565: [lit] Improve the ToolSubst class a bit

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 14:52:10 PDT 2017


rnk added a comment.

This CL contains a lot of whitespace, formatting, and style changes. Can you commit those separately?



================
Comment at: clang/test/lit.cfg.py:230-231
 # Case-insensitive file system
+
+
 def is_filesystem_case_insensitive():
----------------
These new lines seem unnecessary, the comment is associated with this def.


================
Comment at: llvm/test/lit.cfg.py:63-64
 # available. This is darwin specific since it's currently only needed on darwin.
+
+
 def get_asan_rtlib():
----------------
ditto


================
Comment at: llvm/utils/lit/lit/util.py:1
 import errno
 import itertools
----------------
This all looks like style/formatting changes. Can you commit that separately?


https://reviews.llvm.org/D38565





More information about the llvm-commits mailing list