[PATCH] D35844: Correct dwarf unwind information in function epilogue

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added inline comments.


================
Comment at: lib/CodeGen/CFIInstrInserter.cpp:202
+
+  struct MBBCFAInfo PrevMBBInfo = MBBVector[MF.front().getNumber()];
+  const TargetInstrInfo *TII = MF.getSubtarget().getInstrInfo();
----------------
This could be a `const MBBCFAInfo *` to avoid copies.


================
Comment at: lib/CodeGen/CFIInstrInserter.cpp:210
+
+    struct MBBCFAInfo MBBInfo = MBBVector[MBB.getNumber()];
+    auto MBBI = MBBInfo.MBB->begin();
----------------
And this `const MBBCFAInfo &`.


================
Comment at: lib/CodeGen/CFIInstrInserter.cpp:262
+  for (MachineBasicBlock &CurrMBB : MF) {
+    struct MBBCFAInfo CurrMBBInfo = MBBVector[CurrMBB.getNumber()];
+    for (MachineBasicBlock *Pred : CurrMBB.predecessors()) {
----------------
Same.


================
Comment at: lib/CodeGen/CFIInstrInserter.cpp:264
+    for (MachineBasicBlock *Pred : CurrMBB.predecessors()) {
+      struct MBBCFAInfo PredMBBInfo = MBBVector[Pred->getNumber()];
+      // Check that outgoing offset values of predecessors match the incoming
----------------
Same.


================
Comment at: lib/CodeGen/CFIInstrInserter.cpp:292
+    for (MachineBasicBlock *Succ : CurrMBB.successors()) {
+      struct MBBCFAInfo SuccMBBInfo = MBBVector[Succ->getNumber()];
+      // Check that incoming offset values of successors match the outgoing
----------------
Same.


Repository:
  rL LLVM

https://reviews.llvm.org/D35844