[PATCH] D38598: [llvm-objdump] Add RAII for xar apis
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 5 14:02:33 PDT 2017
compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.
================
Comment at: tools/llvm-objdump/MachODump.cpp:205
+struct XarFile {
+ xar_t xar;
----------------
Can you please call this `ScopedXarFile`?
================
Comment at: tools/llvm-objdump/MachODump.cpp:214
+
+struct XarIter {
+ xar_iter_t iter;
----------------
`ScopedXarIter` sounds better
https://reviews.llvm.org/D38598
More information about the llvm-commits
mailing list