[PATCH] D38512: Added phdr upper bound checks to ElfObject

[Rafael Avila de Espindola via llvm-commits]

Committed as r315012.

Thanks,
Rafael

Rafael Avila de Espindola <rafael.espindola at gmail.com> writes:

> Parker Thompson via Phabricator <reviews at reviews.llvm.org> writes:
>
>> mothran added a comment.
>>
>> I updated the diff to correctly use FileCheck with the llvm-objdump output and clang-formated the code in ELF.h.  I don't have commit access so if you could commit on my behalf that would be great.
>
>
> LGTM, I will commit it.
>
>>
>>
>> ================
>> Comment at: include/llvm/Object/ELF.h:147
>>        return createError("invalid e_phentsize");
>> +    if (getHeader()->e_phoff + (getHeader()->e_phnum * getHeader()->e_phentsize) > getBufSize())
>> +      return createError("program headers longer than binary");
>> ----------------
>> davide wrote:
>>> is this clang formatted?
>> Is there a way to cleanly run clang-format across the build to double check for myself?
>
> Using git-clang-format is probably the most convenient.
>
> Cheers,
> Rafael