[compiler-rt] r315011 - [asan] Use full binary path in the Android test runner.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 13:00:20 PDT 2017


Author: eugenis
Date: Thu Oct  5 13:00:19 2017
New Revision: 315011

URL: http://llvm.org/viewvc/llvm-project?rev=315011&view=rev
Log:
[asan] Use full binary path in the Android test runner.

Summary:
This prevents the confusion when there are similarly named tests in
different configurations (like in test/sanitizer_common).

Reviewers: vitalybuka

Subscribers: srhines, llvm-commits, kubamracek

Differential Revision: https://reviews.llvm.org/D38526

Modified:
    compiler-rt/trunk/test/sanitizer_common/android_commands/android_common.py
    compiler-rt/trunk/test/sanitizer_common/android_commands/android_run.py

Modified: compiler-rt/trunk/test/sanitizer_common/android_commands/android_common.py
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/android_commands/android_common.py?rev=315011&r1=315010&r2=315011&view=diff
==============================================================================
--- compiler-rt/trunk/test/sanitizer_common/android_commands/android_common.py (original)
+++ compiler-rt/trunk/test/sanitizer_common/android_commands/android_common.py Thu Oct  5 13:00:19 2017
@@ -1,4 +1,4 @@
-import os, subprocess, tempfile
+import os, sys, subprocess, tempfile
 import time
 
 ANDROID_TMPDIR = '/data/local/tmp/Output'
@@ -8,6 +8,11 @@ verbose = False
 if os.environ.get('ANDROID_RUN_VERBOSE') == '1':
     verbose = True
 
+def host_to_device_path(path):
+    rel = os.path.relpath(path, "/")
+    dev = os.path.join(ANDROID_TMPDIR, rel)
+    return dev
+
 def adb(args, attempts = 1):
     if verbose:
         print args
@@ -37,5 +42,5 @@ def pull_from_device(path):
     return text
 
 def push_to_device(path):
-    dst_path = os.path.join(ANDROID_TMPDIR, os.path.basename(path))
+    dst_path = host_to_device_path(path)
     adb(['push', path, dst_path], 5)

Modified: compiler-rt/trunk/test/sanitizer_common/android_commands/android_run.py
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/android_commands/android_run.py?rev=315011&r1=315010&r2=315011&view=diff
==============================================================================
--- compiler-rt/trunk/test/sanitizer_common/android_commands/android_run.py (original)
+++ compiler-rt/trunk/test/sanitizer_common/android_commands/android_run.py Thu Oct  5 13:00:19 2017
@@ -5,8 +5,7 @@ from android_common import *
 
 ANDROID_TMPDIR = '/data/local/tmp/Output'
 
-here = os.path.abspath(os.path.dirname(sys.argv[0]))
-device_binary = os.path.join(ANDROID_TMPDIR, os.path.basename(sys.argv[0]))
+device_binary = host_to_device_path(sys.argv[0])
 
 def build_env():
     args = []




More information about the llvm-commits mailing list