[PATCH] D34515: [ARM] Materialise some boolean values to avoid a branch

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 12:53:53 PDT 2017


efriedma added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:12128
+      if (Subtarget->isThumb() && !Subtarget->isThumb1Only() &&
+          Subtarget->hasV5TOps()) {
+        // If x == y then x - y == 0 and ARM's CLZ will return 32, shifting it
----------------
What are you trying to do here? With Thumb2, the relevant instructions are basically identical in ARM mode vs. Thumb mode, so doing this transform exclusively in Thumb mode doesn't really make sense.


https://reviews.llvm.org/D34515





More information about the llvm-commits mailing list