[PATCH] D35945: [ELF] - Linkerscript: better diagnostic for INPUT/GROUP commands.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 12:21:25 PDT 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added inline comments.
>
>
> ================
> Comment at: ELF/ScriptParser.cpp:283
> +  if (ErrorCount)
> +    error(">>> location:" + getCurrentLocation());
>  }
> ----------------
> Do not call `error` twice for one error message.
>
> Okay, so I think we need some better infrastructure for diagnostics if we really want to improve linker script diagnostics. That's not that high priority, but it is worth to try. I'll try to create one. Until then, please hold on with and other changes for diagnostics.

What is the status? Should this be rebased?

Cheers,
Rafael


More information about the llvm-commits mailing list