[PATCH] D38588: Clear LastMappingSymbols and LastEMS(Info) when resetting the ARM(AArch64)ELFStreamer

Yichao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 11:43:09 PDT 2017


yuyichao added a comment.

> My guess is that the only way to plausibly test this may be to add a new unittest maybe under unittest/MC?

Yes, that's what I've thought about. I just don't really know how to set it up to trigger the issue and what to test. The questions I have about creating a test for this includes.

- how to setup something so that the same pipeline is used to generate multiple outputs
- what kind of/how to generate inputs will cause the streamer to switch between multiple sections
- how/what to test the output (the segfault would be easy to observe on ARM but the AArch64 version is likely just generating some wrong info)


https://reviews.llvm.org/D38588





More information about the llvm-commits mailing list