[PATCH] D38590: [ARM/AARCH64] Make test MachineBranchProb.ll more robust and re-enable for ARM/AArch64

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 11:05:57 PDT 2017


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM. Enabling the test on ARM/AArch64 is a definite improvement IMO. Just a nit about the placement of the declare



================
Comment at: test/CodeGen/Generic/MachineBranchProb.ll:11
 ; Make sure we have the correct weight attached to each successor.
+declare void @foo()
 define i32 @test2(i32 %x) nounwind uwtable readnone ssp {
----------------
Maybe move this declare above the comment, with an extra blank line?


https://reviews.llvm.org/D38590





More information about the llvm-commits mailing list