[PATCH] D38570: Support: Rewrite Windows implementation of sys::fs::rename to be more POSIXy.

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

I'm with Zach in that I'm also concerned about the extra complexity.  Then again ReplaceFile does all sorts of extra work we don't need (like preserving file creation times) that could potentially create confusion and even bugs.

Would it be reasonble to have the callers cope with the possibility of an access violation and either retry or treat it as a failure?


https://reviews.llvm.org/D38570