[PATCH] D38587: [dsymutil] Emit valid debug locations when no symbol flags are set

[Francis Ricci via Phabricator via llvm-commits]

fjricci added inline comments.


================
Comment at: tools/dsymutil/MachODebugMapParser.cpp:485
     // addresses should be fetched for the debug map.
-    if (!(Sym.getFlags() & SymbolRef::SF_Global))
+    if (Sym.getFlags() && !(Sym.getFlags() & SymbolRef::SF_Global))
       continue;
----------------
fjricci wrote:
> aprantl wrote:
> > Note that 
> > 
> > https://opensource.apple.com/source/clang/clang-800.0.42.1/src/tools/dsymutil/MachODebugMapParser.cpp.auto.html
> > 
> > uses SymbolRef::SF_Common instead.
> Ah, I didn't realize that the apple fork was open source as well. Are there plans to merge it back into llvm? (probably applies to https://reviews.llvm.org/D38504 as well)
If there are plans to eventually merge the two, these two diffs are just going to cause the forks to diverge and make merging harder (unless I merge them in as copies from what's in the apple version)


https://reviews.llvm.org/D38587