[PATCH] D38588: Clear LastMappingSymbols and LastEMS(Info) when resetting the ARM(AArch64)ELFStreamer

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 09:02:37 PDT 2017


rengolin added a comment.

I don't see anything terribly wrong in cleaning up between object emissions, but I'll let @t.p.northover and @peter.smith make sure this can't be done in a better way (like fixing the original patch), in which case, we might want at least an assert here.



================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:1172
   MCELFStreamer::reset();
+  LastMappingSymbols.clear();
+  LastEMSInfo.reset();
----------------
Why do you need to call this here and in `reset()`?


https://reviews.llvm.org/D38588





More information about the llvm-commits mailing list