[PATCH] D38587: [dsymutil] Emit valid debug locations when no symbol flags are set

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 08:52:23 PDT 2017


aprantl added inline comments.


================
Comment at: tools/dsymutil/MachODebugMapParser.cpp:485
     // addresses should be fetched for the debug map.
-    if (!(Sym.getFlags() & SymbolRef::SF_Global))
+    if (Sym.getFlags() && !(Sym.getFlags() & SymbolRef::SF_Global))
       continue;
----------------
Note that 

https://opensource.apple.com/source/clang/clang-800.0.42.1/src/tools/dsymutil/MachODebugMapParser.cpp.auto.html

uses SymbolRef::SF_Common instead.


https://reviews.llvm.org/D38587





More information about the llvm-commits mailing list