[PATCH] D38540: Ignore duplicated, identical fragment declarations

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 08:45:25 PDT 2017


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:240
+          return FIE.FI == Other.FI && FIE.Expr == Other.Expr;
+        }))
+      FrameIndexExprs.push_back(FIE);
----------------
This strips out true duplicates (which was the *intention* behind the old code). The old code also deleted all but the first non-fragment entry.

This only affects inputs that are arguably already broken (two non-fragment entries for the same variable at different frame indices), so I don't think the old behavior is worth keeping.


https://reviews.llvm.org/D38540





More information about the llvm-commits mailing list