[PATCH] D38501: [ValueTracking] Fix a misuse of APInt in GetPointerBaseWithConstantOffset

[Michael Ferguson via Phabricator via llvm-commits]

mppf added a comment.

@aprantl / @hfinkel - I improved the test, does it look better? Oddly enough the code necessary to trigger the assert is in a section that isn't meaningfully changed by GVN. I just beefed up the test to also show a related case that GVN did usefully change. I'm having trouble doing any better than that with a reasonable amount of effort.

This one needs to merge after https://reviews.llvm.org/D38499, but other than that is it ready to go? Or does something else need to happen here?

Thanks!


https://reviews.llvm.org/D38501