[PATCH] D38360: [ELF] Set Dot initially to --image-base value when using linker scripts
    James Henderson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Oct  5 06:36:58 PDT 2017
    
    
  
jhenderson updated this revision to Diff 117810.
jhenderson added a comment.
Addressed review comments.
I'm not sure where to put the new getImageBase function, because it is needed in SyntheticSections.cpp as well as LinkerScript.cpp. To me it feels like it really belongs as a member of the Configuration class, but that is currently made up entirely of variables, and no methods, so I've put it in the LinkerScript class. I'm open to other suggestions.
https://reviews.llvm.org/D38360
Files:
  ELF/Config.h
  ELF/Driver.cpp
  ELF/LinkerScript.cpp
  ELF/LinkerScript.h
  ELF/SyntheticSections.cpp
  test/ELF/linkerscript/image-base.s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38360.117810.patch
Type: text/x-patch
Size: 4954 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171005/7f973e35/attachment.bin>
    
    
More information about the llvm-commits
mailing list