[PATCH] D38407: [ELF] - Do --hash-style=both by default.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I created https://reviews.llvm.org/D38573 to show you what I meant by my previous comment. Please apply it to your patch.

Basically, if you want to name a function "finalize", it is likely a sign that that is not a good name nor a good function. It just says "it runs at last" and doesn't really explain what the function does. Such function is easy to become a kitchen sink. So, if you try to name your function "finalize" next time, you probably should stop and think about what your function actually does. In most cases, you shouldn't name a function "finalize".


https://reviews.llvm.org/D38407