[PATCH] D38554: Fixed ppc32 function relocations in non-pic mode

[vit9696 via Phabricator via llvm-commits]

vit9696 added a comment.

In https://reviews.llvm.org/D38554#888873, @joerg wrote:

> In that case: the short version is that there is no EABI support at the moment. That patch changes the behavior for SYSV ABI, it is not acceptable as such. The test case doesn't reflect the ABI variance either.


The only thing I could imagine to be relevant is https://reviews.llvm.org/diffusion/L/browse/cfe/trunk/lib/Driver/ToolChains/Gnu.cpp;314943$2187, that does not handle llvm::Triple::ppc case. As a result fpic has always been off for PPC32 by default, however, starting with LLVM 3.9.x PLT was "accidentally" always on, making the result be "partially?" PIC.

I could add the case there, if it is what you mean and that is the desired behaviour. However, I strongly ask you to be as constructive as possible.


https://reviews.llvm.org/D38554