[PATCH] D38537: [mips] Implement .set dspr2 directive

[Petar Jovanovic via Phabricator via llvm-commits]

petarj added inline comments.


================
Comment at: test/MC/Mips/set-nodsp.s:1
-# RUN: not llvm-mc %s -mcpu=mips32 -mattr=+dsp -triple mips-unknown-linux 2>%t1
+# RUN: not llvm-mc %s -mcpu=mips32 -mattr=+dsp -mattr=+dspr2 -triple mips-unknown-linux 2>%t1
 # RUN: FileCheck %s < %t1
----------------
-mattr=+dsp seems redundant in presence of -mattr=+dspr2

Furthermore, DSP extension requires Rev2 at least, so the test should probable have -mcpu=mips32r2

GCC has a warning like:

"//Warning: the `dsp' extension requires MIPS32 revision 2 or greater'//"

It seems that LLVM does not do that. Maybe it should?


https://reviews.llvm.org/D38537