[PATCH] D38554: Fixed ppc32 function relocations in non-pic mode

vit9696 via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 4 13:59:05 PDT 2017


vit9696 added a comment.

In https://reviews.llvm.org/D38554#888745, @joerg wrote:

> This doesn't look right to me at all. The normal SYSV ABI on PowerPC is effectively PIC, with a few edge cases. This really looks like a step backwards.


Please clarify what exactly you do not like. I am afraid I did not understand you. Currently you have PLT on regardless of whether you are compiling with PIC and whether you are not. This change fixes it allowing one not to use PLT in non-PIC mode, and it does not break PIC mode anyhow.


https://reviews.llvm.org/D38554





More information about the llvm-commits mailing list