[PATCH] D38504: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 4 13:29:17 PDT 2017
aprantl added inline comments.
================
Comment at: lib/MC/MCObjectFileInfo.cpp:217
+ // Swift AST Section
+ DwarfSwiftASTSection =
----------------
this comment doesn't really add anything. I would either explain what that section is or remove it.
================
Comment at: tools/dsymutil/DwarfLinker.cpp:3491
+ // N_AST objects (swiftmodule files) should get dumped directly into the
+ // appropriate DWARF section
+ if (Obj->getType() == MachO::N_AST) {
----------------
`.` at the end, llvm coding guides always want full setences.
https://reviews.llvm.org/D38504
More information about the llvm-commits
mailing list