[PATCH] D38512: Added phdr upper bound checks to ElfObject

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

In https://reviews.llvm.org/D38512#888639, @mothran wrote:

> I am unable to construct a correctly malformed file with yaml2obj, but was able to create a test with hexedit.


I'm surprised you can't craft with yaml2obj. What's the problem? If it's a limitation in yaml2obj we might consider fixing it.

> This is my first time committing a patch to LLVM and was wondering, do I have to use arc to submit a patch with a binary file?  And should I do that as a follow up commit or a whole new review and one patch?

You should attach your test (whatever it is) to the same patch, so it's grouped logically (and it' easier to bisect, revert, doing archeology, etc..)


https://reviews.llvm.org/D38512