[PATCH] D38529: [IRCE] Temporarily disable unsigned latch conditions by default

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/trunk/test/Transforms/IRCE/range_intersect_miscompile.ll:3
+
+; This test demonstrates a miscompile: the outer loop's IV iterates in range of
+; [2, 400) and the range check is done against value 331. Due to a bug in range
----------------
This comment needs clarified.  It reads as if this is an active miscompile.  After you disabled the unsigned latch case, this is no longer active.  

Another way of structuring this would be to write the test using the off-by-default output and check the incorrect output matches what you expect.  Then you'd have a test case to edit to show the effect of fixing the miscompile when you re-enable the unsigned latch.


Repository:
  rL LLVM

https://reviews.llvm.org/D38529