[PATCH] D38428: Add FileVerifier::isCFIProtected().

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added a comment.

On a mechanical note, you should add `-U999999` to your git diff options to include full files in the diff (makes scrolling below/above added/removed lines possible in the web view)



================
Comment at: tools/llvm-cfi-verify/FileVerifier.cpp:102
+
+  bool UsesRegisterOperand = false;
+  for (const auto &Operand : InstrMetaPtr->Instruction)
----------------
This is checked in two different places, might be worth having a helper function?


================
Comment at: tools/llvm-cfi-verify/FileVerifier.cpp:112
+
+  if (!Flows.OrphanedNodes.empty())
+    return false;
----------------
This would be a surprising reason to see 'Protected? No.' Perhaps worth making this an enum return value with no/yes/could-not-be-determined?


https://reviews.llvm.org/D38428