[PATCH] D38027: [X86] Add new attribute to X86 instructions to enable marking them as "not memory foldable"

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86InstrSSE.td:3211
+                      SSEPackedSingle, itins, "SS">, XS, VEX_4V, VEX_LIG, VEX_WIG,
+                      NotMemoryFoldable;
 }
----------------
aymanmus wrote:
> craig.topper wrote:
> > Why are AVX and SSE different here?
> > 
> > This looks like it corresponds to things like VSQRTSSr which I see in the folding table today.
> The SSE version has an actual partial register update (listed under hasPartialRegUpdate function in X86InstrInfo.cpp) which is dealt with by a special handling in the folding process.
I thought the goal was to make tablegen generate the equivalent of the manual table so shouldn't these instructions be included to match the table?


https://reviews.llvm.org/D38027