[PATCH] D37343: [CGP] Merge empty case blocks if no extra moves are added.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 3 17:25:25 PDT 2017


efriedma added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:954
   BB->eraseFromParent();
+  if (BB->getParent() == DestBB->getParent() && BB != DestBB)
+    DT->deleteEdge(BB, DestBB);
----------------
"BB->getParent() == DestBB->getParent()"?

Also, you can't use the pointer "BB" after you free it (so this needs to be before the eraseFromParent() call.)


https://reviews.llvm.org/D37343





More information about the llvm-commits mailing list