[PATCH] D38515: Fix ISO C++ fnptr -> objptr errors.

[Mitch Phillips via Phabricator via llvm-commits]

hctim added a comment.

FYI: current default LLVM build errors list:

  [565/4353] Building CXX object projects/compiler-rt/...les/clang_rt.stats_client-i386.dir/stats_client.cc.o
  <REDACTED>/llvm/projects/compiler-rt/lib/stats/stats_client.cc: In constructor ‘{anonymous}::RegisterSanStats::RegisterSanStats()’:
  <REDACTED>/llvm/projects/compiler-rt/lib/stats/stats_client.cc:50:59: warning: ISO C++ forbids casting between pointer-to-function and pointer-to-object [-Wpedantic]
           LookupSymbolFromMain("__sanitizer_stats_register"));
                                                             ^
  <REDACTED>/llvm/projects/compiler-rt/lib/stats/stats_client.cc: In destructor ‘{anonymous}::RegisterSanStats::~RegisterSanStats()’:
  <REDACTED>/llvm/projects/compiler-rt/lib/stats/stats_client.cc:58:61: warning: ISO C++ forbids casting between pointer-to-function and pointer-to-object [-Wpedantic]
           LookupSymbolFromMain("__sanitizer_stats_unregister"));
                                                               ^
  [619/4353] Building CXX object projects/compiler-rt/...ibc.i386.dir/sanitizer_symbolizer_posix_libcdep.cc.o
  <REDACTED>/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc: In function ‘void __sanitizer::InitializeSwiftDemangler()’:
  <REDACTED>/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:79:77: warning: ISO C++ forbids casting between pointer-to-function and pointer-to-object [-Wpedantic]
     swift_demangle_f = (swift_demangle_ft)dlsym(RTLD_DEFAULT, "swift_demangle");
                                                                               ^
  [641/4353] Building CXX object projects/compiler-rt/...s/clang_rt.stats_client-x86_64.dir/stats_client.cc.o
  <REDACTED>/llvm/projects/compiler-rt/lib/stats/stats_client.cc: In constructor ‘{anonymous}::RegisterSanStats::RegisterSanStats()’:
  <REDACTED>/llvm/projects/compiler-rt/lib/stats/stats_client.cc:50:59: warning: ISO C++ forbids casting between pointer-to-function and pointer-to-object [-Wpedantic]
           LookupSymbolFromMain("__sanitizer_stats_register"));
                                                             ^
  <REDACTED>/llvm/projects/compiler-rt/lib/stats/stats_client.cc: In destructor ‘{anonymous}::RegisterSanStats::~RegisterSanStats()’:
  <REDACTED>/llvm/projects/compiler-rt/lib/stats/stats_client.cc:58:61: warning: ISO C++ forbids casting between pointer-to-function and pointer-to-object [-Wpedantic]
           LookupSymbolFromMain("__sanitizer_stats_unregister"));
                                                               ^
  [672/4353] Building CXX object projects/compiler-rt/...c.x86_64.dir/sanitizer_symbolizer_posix_libcdep.cc.o
  <REDACTED>/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc: In function ‘void __sanitizer::InitializeSwiftDemangler()’:
  <REDACTED>/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:79:77: warning: ISO C++ forbids casting between pointer-to-function and pointer-to-object [-Wpedantic]
     swift_demangle_f = (swift_demangle_ft)dlsym(RTLD_DEFAULT, "swift_demangle");
                                                                               ^
  [713/4353] Building C object projects/compiler-rt/li...ins/CMakeFiles/clang_rt.builtins-i386.dir/divtc3.c.o
  <REDACTED>/llvm/projects/compiler-rt/lib/builtins/divtc3.c:21:1: warning: conflicting types for built-in function ‘__divtc3’ [enabled by default]
   __divtc3(long double __a, long double __b, long double __c, long double __d)
   ^
  [2352/4353] Building C object projects/compiler-rt/l...s/CMakeFiles/clang_rt.builtins-x86_64.dir/divtc3.c.o
  <REDACTED>/llvm/projects/compiler-rt/lib/builtins/divtc3.c:21:1: warning: conflicting types for built-in function ‘__divtc3’ [enabled by default]
   __divtc3(long double __a, long double __b, long double __c, long double __d)
   ^
  [2522/4353] Building CXX object projects/compiler-rt...b/msan/CMakeFiles/clang_rt.msan-x86_64.dir/msan.cc.o
  <REDACTED>/llvm/projects/compiler-rt/lib/msan/msan.cc: In function ‘__sanitizer::u16 __sanitizer_unaligned_load16(const uu16*)’:
  <REDACTED>/llvm/projects/compiler-rt/lib/msan/msan.cc:586:32: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     *(uu16 *)&__msan_retval_tls[0] = *(uu16 *)MEM_TO_SHADOW((uptr)p);
                                  ^
  <REDACTED>/llvm/projects/compiler-rt/lib/msan/msan.cc: In function ‘__sanitizer::u32 __sanitizer_unaligned_load32(const uu32*)’:
  <REDACTED>/llvm/projects/compiler-rt/lib/msan/msan.cc:592:32: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     *(uu32 *)&__msan_retval_tls[0] = *(uu32 *)MEM_TO_SHADOW((uptr)p);
                                  ^
  <REDACTED>/llvm/projects/compiler-rt/lib/msan/msan.cc: In function ‘void __sanitizer_unaligned_store16(__sanitizer::uu16*, __sanitizer::u16)’:
  <REDACTED>/llvm/projects/compiler-rt/lib/msan/msan.cc:604:39: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     u16 s = *(uu16 *)&__msan_param_tls[1];
                                         ^
  <REDACTED>/llvm/projects/compiler-rt/lib/msan/msan.cc: In function ‘void __sanitizer_unaligned_store32(__sanitizer::uu32*, __sanitizer::u32)’:
  <REDACTED>/llvm/projects/compiler-rt/lib/msan/msan.cc:612:39: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     u32 s = *(uu32 *)&__msan_param_tls[1];
                                         ^
  [2792/4353] Building CXX object projects/compiler-rt...Ubsan_minimal.x86_64.dir/ubsan_minimal_handlers.cc.o
  <REDACTED>/llvm/projects/compiler-rt/lib/ubsan_minimal/ubsan_minimal_handlers.cc: In function ‘void message(const char*)’:
  <REDACTED>/llvm/projects/compiler-rt/lib/ubsan_minimal/ubsan_minimal_handlers.cc:7:29: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
     write(2, msg, strlen(msg));
                               ^
  [2797/4353] Building CXX object projects/compiler-rt...RTUbsan_minimal.i386.dir/ubsan_minimal_handlers.cc.o
  <REDACTED>/llvm/projects/compiler-rt/lib/ubsan_minimal/ubsan_minimal_handlers.cc: In function ‘void message(const char*)’:
  <REDACTED>/llvm/projects/compiler-rt/lib/ubsan_minimal/ubsan_minimal_handlers.cc:7:29: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
     write(2, msg, strlen(msg));
                               ^
  [2862/4353] Building CXX object projects/compiler-rt...r/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerIOPosix.cpp.o
  <REDACTED>/llvm/projects/compiler-rt/lib/fuzzer/FuzzerIOPosix.cpp: In function ‘void fuzzer::RawPrint(const char*)’:
  <REDACTED>/llvm/projects/compiler-rt/lib/fuzzer/FuzzerIOPosix.cpp:125:29: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
     write(2, Str, strlen(Str));
                               ^
  [3207/4353] Generating SVNVersion.inc
  -- Found Subversion: /usr/bin/svn (found version "1.8.8") 
  [3289/4353] Building CXX object projects/compiler-rt.../clang_rt.tsan-x86_64.dir/rtl/tsan_interceptors.cc.o
  <REDACTED>/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:374:28: warning: ISO C99 requires rest arguments to be used [enabled by default]
   TSAN_INTERCEPTOR(int, pause) {
                              ^
  <REDACTED>/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:375:32: warning: ISO C99 requires rest arguments to be used [enabled by default]
     SCOPED_TSAN_INTERCEPTOR(pause);
                                  ^


https://reviews.llvm.org/D38515