[PATCH] D38407: [ELF] - Do --hash-style=both by default.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:259-261
   // The MIPS ABI as of 2016 does not support the GNU-style symbol lookup
-  // table which is a relatively new feature.
-  if (Config->EMachine == EM_MIPS && Config->GnuHash)
-    error("the .gnu.hash section is not compatible with the MIPS target.");
+  // table which is a relatively new feature. Other targets defaults to
+  // both GNU and classic ELF hash styled sections.
----------------
This function is not a place to put this code, as described in the function comment. This function checks for validity of option combinations. You shouldn't set a new value to a Config member.


https://reviews.llvm.org/D38407