[PATCH] D38387: AMDGPU: Add ELFOSABI_AMDGPU_MESA3D

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 3 14:15:47 PDT 2017


t-tye accepted this revision.
t-tye added a comment.

LGTM (couple minor documentation suggestions)



================
Comment at: docs/AMDGPUUsage.rst:367
      ``e_ident[EI_DATA]``       ``ELFDATA2LSB``
      ``e_ident[EI_OSABI]``      ``ELFOSABI_AMDGPU_HSA`` or
+                                ``ELFOSABI_AMDGPU_PAL`` or
----------------
or -> ,


================
Comment at: docs/AMDGPUUsage.rst:370
+                                ``ELFOSABI_AMDGPU_MESA3D``
      ``e_ident[EI_ABIVERSION]`` ``ELFABIVERSION_AMDGPU_HSA`` or
+                                ``ELFABIVERSION_AMDGPU_PAL`` or
----------------
or -> ,


https://reviews.llvm.org/D38387





More information about the llvm-commits mailing list