[PATCH] D38341: [compiler-rt] Add back ARM EABI aliases where legal.

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 3 13:40:47 PDT 2017


compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Thanks for finding and fixing the performance regression on the older targets!



================
Comment at: lib/builtins/fixdfdi.c:49
+#if defined(COMPILER_RT_ARMHF_TARGET)
+AEABI_RTABI di_int __aeabi_d2lz(fp_t a) {
   return __fixdfdi(a);
----------------
Nice, thanks for the drive-by fix here.


================
Comment at: lib/builtins/int_lib.h:26
   void alias_name() __attribute__((alias(#original_name)))
+#define COMPILER_RT_ALIAS(aliasee) __attribute__((alias(#aliasee)))
 #else
----------------
Please use the reserved spelling `__attribute__((__alias__(#aliasee)))`


Repository:
  rL LLVM

https://reviews.llvm.org/D38341





More information about the llvm-commits mailing list