[PATCH] D38415: [SimplifyIndVar] Replace IVUsers with loop invariant if possible

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Transforms/Utils/SimplifyIndVar.cpp:553
+  // If I is the LCSSA phi, L will not contain UserL, skip I in this case
+  if (!L->contains(UserL))
+    return false;
----------------
etherzhhb wrote:
> Maybe we should not push IV users in pushIVUsers at all if IV users do not in the IV loop (e.g. LCSSA phi)
Yeah, that makes sense; we have special handling for exit values in IndVarSimplify::rewriteLoopExitValues.


Repository:
  rL LLVM

https://reviews.llvm.org/D38415