[PATCH] D38436: [llvm-objcopy] Fix major layout bugs in llvm-objcopy

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added inline comments.


================
Comment at: test/tools/llvm-objcopy/segment-shift.test:56
+# CHECK-NEXT:    Offset: 0x2000
+# CHECK-NEXT:    VirtualAddress: 0x0
+# CHECK-NEXT:    PhysicalAddress: 0x0
----------------
jhenderson wrote:
> This address looks wrong. Shouldn't it be 0x3000, i.e. the address of .text3?
In yaml2obj the addresses of the program headers default to 0x0 and the user has to manually add them (this "feature" of yaml2obj is my fault). I'll add the desired addresses to make things consistent


Repository:
  rL LLVM

https://reviews.llvm.org/D38436