[PATCH] D38499: [BasicAA] Fix adjustToPointerSize in BasicAliasAnalysis.cpp for ptr > 64b

[Eli Friedman via Phabricator via llvm-commits]

efriedma requested changes to this revision.
efriedma added a comment.
This revision now requires changes to proceed.

Hang on, there's a more fundamental problem here this is papering over.  If your pointers are larger than 64 bits, those pointers can have offsets larger than 64 bits.  Since BasicAA is using 64-bit integers to represent pointer offsets, the math in DecomposeGEPExpression will overflow, so you'll get incorrect results, and eventually cause a miscompile.


https://reviews.llvm.org/D38499