[PATCH] D38154: [PassManager] Run global opts after the inliner

[Michael Zolotukhin via Phabricator via llvm-commits]

mzolotukhin added a comment.

> Which part is cumbersome?

I was talking about `compare.py` specifically. Namely, it uses `pandas` package, which is not as commonly installed as others, and installing it wasn't very easy/fast if I remember it correctly. All I wanted to say is that these tools are required some getting used to and might not work from the first try, and in case of `compare.py` you might want to not use if you only need to do it once.

> Can definitely get multiple runs with lit directly, no need for virtualenv or LNT... In fact, AFAIK, LNT just uses lit to do all of this already. LNT seems really focused on running a server and collecting and aggregating results over time, rather than checking a single commit.

This is true, one can run the same commands with cmake+make/ninja, and that'll give absolutely the same results. `lnt runtest` is just a wrapper for this.

> On the other hand I never found any similar convenience with the cmake/lit use of the test-suite (maybe too young to have proper support?).

That actually surprised me. It should be pretty identical (at least now). Have you tried it recently?

> The only feature missing was that of having a lit-like set of checks to make sure your changes didn't screw up compile time.

That's an interesting idea. I'm actually going to give a small refresher on how to collect compile-time results on LLVM Dev, we can discuss what can be improved in that area there.

Michael


https://reviews.llvm.org/D38154