[PATCH] D38499: [BasicAA] Fix adjustToPointerSize in BasicAliasAnalysis.cpp for ptr > 64b

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

This seems to match the intended semantics of the function based on the doxygen comment, so this change LGTM. Ideally, the test should check an actual result of the analysis pass rather than "don't crash".



================
Comment at: lib/Analysis/BasicAliasAnalysis.cpp:363
 /// (in bits) when that size is smaller than 64. This is an issue in
 /// particular for 32b programs with negative indices that rely on two's
 /// complement wrap-arounds for precise alias information.
----------------
s/32b/32bit/ ?


================
Comment at: test/Analysis/BasicAA/128-bit-ptr.ll:18
+; CHECK-LABEL: @test1(
+; CHECK: ret i64
+}
----------------
I would prefer it if the CHECK would test for some actual result of the analysis if possible.


https://reviews.llvm.org/D38499