[PATCH] D35844: Correct dwarf unwind information in function epilogue

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 3 09:03:51 PDT 2017


aprantl added inline comments.


================
Comment at: include/llvm/Target/TargetFrameLowering.h:346
+  // Return initial CFA offset value i.e. the one valid at the beginning of the
+  // function (before any stack operations).
+  virtual int getInitialCFAOffset(MachineFunction &MF) const;
----------------
`///` please


================
Comment at: lib/CodeGen/CFIInstrInserter.cpp:64
+    MachineBasicBlock *MBB;
+    // Value of cfa offset valid at basic block entry.
+    int IncomingCFAOffset = -1;
----------------
please use `///` for all comments describing declarations.


Repository:
  rL LLVM

https://reviews.llvm.org/D35844





More information about the llvm-commits mailing list