[PATCH] D38491: [ELF] Decompress debug info sections early

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: test/ELF/compressed-debug-conflict.s:5
+
+# CHECK:      error: duplicate symbol: main
+# CHECK-NEXT: >>> defined at reduced.c:2 (/tmp/reduced.c:2)
----------------
grimar wrote:
> As far I remember, if compressed section size is greater then uncompressed, then
> producer (llvm-mc) will not compress it. 
> I would add check here to verify that input object contains SHF_COMPRESSED section.
That's a good idea.


================
Comment at: test/ELF/compressed-debug-conflict.s:19
+	retl
+	.file	2 "/tmp/repeat/repeat/repeat/repeat" "repeat.h"
----------------
grimar wrote:
> I guess that is why you duplicated "repeat" here: to increase debug info size to force section be compressed, right ?
Yup, since zlib will be able to compress the repeats well and get the compressed size below the uncompressed size.


https://reviews.llvm.org/D38491