[PATCH] D38507: [llvm-cov] Fix showing title when filtering and not outputting to a directory
Sean Eveson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 3 08:36:02 PDT 2017
seaneveson created this revision.
Fix an accidental side effect of r314310 (https://reviews.llvm.org/D38280) where the coverage title was being written to stdout when filtering without an output directory.
https://reviews.llvm.org/D38507
Files:
tools/llvm-cov/CodeCoverage.cpp
Index: tools/llvm-cov/CodeCoverage.cpp
===================================================================
--- tools/llvm-cov/CodeCoverage.cpp
+++ tools/llvm-cov/CodeCoverage.cpp
@@ -882,7 +882,7 @@
}
auto OS = std::move(OSOrErr.get());
- bool ShowTitle = true;
+ bool ShowTitle = ViewOpts.hasOutputDirectory();
for (const auto *Function : Functions) {
auto FunctionView = createFunctionView(*Function, *Coverage);
if (!FunctionView) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38507.117534.patch
Type: text/x-patch
Size: 495 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171003/7cdb8799/attachment.bin>
More information about the llvm-commits
mailing list