[PATCH] D38073: [XRay][compiler-rt] Use pthread for initializing thread-local data

[Philip Douglas via Phabricator via llvm-commits]

pdouglas added a comment.

Hi,

This change appears to be causing three test failures on several buildbots:

  FAIL: XRay-Unit :: unit/./XRayBufferQueueTest-powerpc64le-Test/BufferQueueTest.Apply (36360 of 36408)
  ******************** TEST 'XRay-Unit :: unit/./XRayBufferQueueTest-powerpc64le-Test/BufferQueueTest.Apply' FAILED ********************
  Note: Google Test filter = BufferQueueTest.Apply
  [==========] Running 1 test from 1 test case.
  [----------] Global test environment set-up.
  [----------] 1 test from BufferQueueTest
  [ RUN      ] BufferQueueTest.Apply
  /home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/llvm/projects/compiler-rt/lib/xray/tests/unit/buffer_queue_test.cc:107: Failure
        Expected: Buffers.getBuffer(B)
        Which is: 4-byte object <01-00 00-00>
  To be equal to: BufferQueue::ErrorCode::Ok
        Which is: 4-byte object <00-00 00-00>
  [  FAILED  ] BufferQueueTest.Apply (0 ms)
  [----------] 1 test from BufferQueueTest (0 ms total)
  
  [----------] Global test environment tear-down
  [==========] 1 test from 1 test case ran. (0 ms total)
  [  PASSED  ] 0 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] BufferQueueTest.Apply
  
   1 FAILED TEST
  
  ********************
  PASS: XRay-Unit :: unit/./XRayBufferQueueTest-powerpc64le-Test/BufferQueueTest.ErrorsWhenFinalising (36361 of 36408)
  FAIL: XRay-Unit :: unit/./XRayBufferQueueTest-powerpc64le-Test/BufferQueueTest.GetAndRelease (36362 of 36408)
  ******************** TEST 'XRay-Unit :: unit/./XRayBufferQueueTest-powerpc64le-Test/BufferQueueTest.GetAndRelease' FAILED ********************
  Note: Google Test filter = BufferQueueTest.GetAndRelease
  [==========] Running 1 test from 1 test case.
  [----------] Global test environment set-up.
  [----------] 1 test from BufferQueueTest
  [ RUN      ] BufferQueueTest.GetAndRelease
  /home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/llvm/projects/compiler-rt/lib/xray/tests/unit/buffer_queue_test.cc:36: Failure
        Expected: Buffers.releaseBuffer(Buf)
        Which is: 4-byte object <01-00 00-00>
  To be equal to: BufferQueue::ErrorCode::Ok
        Which is: 4-byte object <00-00 00-00>
  [  FAILED  ] BufferQueueTest.GetAndRelease (0 ms)
  [----------] 1 test from BufferQueueTest (0 ms total)
  
  [----------] Global test environment tear-down
  [==========] 1 test from 1 test case ran. (0 ms total)
  [  PASSED  ] 0 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] BufferQueueTest.GetAndRelease
  
   1 FAILED TEST
  
  ********************
  PASS: XRay-Unit :: unit/./XRayBufferQueueTest-powerpc64le-Test/BufferQueueTest.API (36363 of 36408)
  FAIL: XRay-Unit :: unit/./XRayBufferQueueTest-powerpc64le-Test/BufferQueueTest.GetUntilFailed (36364 of 36408)
  ******************** TEST 'XRay-Unit :: unit/./XRayBufferQueueTest-powerpc64le-Test/BufferQueueTest.GetUntilFailed' FAILED ********************
  Note: Google Test filter = BufferQueueTest.GetUntilFailed
  [==========] Running 1 test from 1 test case.
  [----------] Global test environment set-up.
  [----------] 1 test from BufferQueueTest
  [ RUN      ] BufferQueueTest.GetUntilFailed
  /home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/llvm/projects/compiler-rt/lib/xray/tests/unit/buffer_queue_test.cc:48: Failure
        Expected: Buffers.releaseBuffer(Buf0)
        Which is: 4-byte object <01-00 00-00>
  To be equal to: BufferQueue::ErrorCode::Ok
        Which is: 4-byte object <00-00 00-00>
  [  FAILED  ] BufferQueueTest.GetUntilFailed (0 ms)
  [----------] 1 test from BufferQueueTest (0 ms total)
  
  [----------] Global test environment tear-down
  [==========] 1 test from 1 test case ran. (0 ms total)
  [  PASSED  ] 0 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] BufferQueueTest.GetUntilFailed
  
   1 FAILED TEST
  
  ********************


Repository:
  rL LLVM

https://reviews.llvm.org/D38073