[PATCH] D38312: adding pattern for broadcastm

jina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 23:34:00 PDT 2017


jina.nahias added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:6608
+// If so, return the value extended.
+static SDValue isSplatZeroExtended(const BuildVectorSDNode *Op,
+                                   unsigned &NumElt, MVT &EltType) {
----------------
RKSimon wrote:
> Describe the function NumElt and EltType, also I'm not convinced that 'isSplatZeroExtended' is suitably descriptive of what the function is actually doing.
i could not find a better name. do you have one? 


https://reviews.llvm.org/D38312





More information about the llvm-commits mailing list