[PATCH] D38490: [ObjectYAML] Handle SHF_COMPRESSED

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 22:31:47 PDT 2017


smeenai added inline comments.


================
Comment at: test/tools/yaml2obj/shf-compressed.yaml:1-2
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-readobj -sections %t | FileCheck %s
+
----------------
davide wrote:
> if you really want to make this test slightly fancier, you can test that the outputs of `yaml2obj` and `obj2yaml` are the same up to isomorphism (for some very relaxed definition of isomorphism, as you're not guaranteed that converting and then converting back will give you the original object for a series of reason).
I didn't go that fancy, but I did add verification that the obj2yaml output includes the flag.


https://reviews.llvm.org/D38490





More information about the llvm-commits mailing list