[PATCH] D38482: TargetMachine: Use LLVMTargetMachine in CodeGen

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D38482#886603, @echristo wrote:

> Hi Matthias,
>
> Similar to Chandler's comments I think we should look at folding these two together rather than keeping them split apart. I started working a little bit in this direction at one point, but admittedly got distracted by other things. A more concrete thought here is that we could either move all of the bits over into the TargetMachine and for something that doesn't need it then that target could simply just not initialize or define those initialization routines (I don't recall anything that doesn't currently need). It might end up being a bit more verbose in a couple of targets, but seems like a reasonable start.
>
> Thoughts?


See my response to Chandler. Right now it feels neat to have an internal/external interface. But that's probably because I spent the time preparing the patch :) Merging the two together to have one less concept/class doesn't sound too bad either (and needs less changes). Let me sleep over it.


Repository:
  rL LLVM

https://reviews.llvm.org/D38482