[PATCH] D36706: DAGCombiner: Add form of isFPExtFree to check uses
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 2 18:13:40 PDT 2017
arsenm added a comment.
In https://reviews.llvm.org/D36706#843207, @RKSimon wrote:
> Given its limited use I don't see why we shouldn't just update the existing isFPExtFree to take Opcode, SrcVT and DstVT - all of which may be useful.
The problem with the opcode is this does have a caller from the IR path from codegenprepare (although this feature doesn't seem to be hit by any tests in tree), so there needs to at least be a different one for that. Adding the other VT just makes this messier, since now it is more context dependent.
https://reviews.llvm.org/D36706
More information about the llvm-commits
mailing list